0xfe / vexflow

A JavaScript library for rendering music notation and guitar tablature.
http://www.vexflow.com
Other
3.89k stars 661 forks source link

How to represent ghost notes in drums #654

Closed ghost closed 2 years ago

ghost commented 6 years ago

In drum notation, ghost notes are represented with the note head surrounded by parenthesis (see https://en.wikipedia.org/wiki/Ghost_note#/media/File:Ghost_note_drumming.png). I see that this notation exists for tablatures, however I was wondering how I could use it with "standard" notation ?

jeroenlammerts commented 4 years ago

There is noteheadBlackParens in Smufl. https://w3c.github.io/smufl/gitbook/tables/noteheads.html

rvilarl commented 2 years ago

noteheadBlackParens can be found in http://www.smufl.org/files/smufl-1.18.pdf and the glyphs are available in Bravura OTF file.

rvilarl commented 2 years ago

@0xfe I would suggest to use p for Parenthesised. Would you agree to add this feature?

const validNoteTypes: Record<string, { name: string }> = {
  n: { name: 'note' },
  r: { name: 'rest' },
  h: { name: 'harmonic' },
  m: { name: 'muted' },
  s: { name: 'slash' },
  p: { name: 'parenthesized' },
};
0xfe commented 2 years ago

Yes, that sounds good.