search

0xfe / vextab

A VexTab Parser for VexFlow
Other
588 stars 115 forks source link

Webpack libraryTarget set to UMD #113

Closed pasho closed 3 years ago

pasho commented 3 years ago

fixes #112

Specified library target to be UMD, which makes the api importable. All the existing code examples and tests work.

leocaseiro commented 3 years ago

Hey @0xfe, could you please consider this PR? It would be nice to use es6 import with vextab.

Thanks

leocaseiro commented 3 years ago

For context, I've being trying to use it with React on codesandbox, but I've got the same issue as mentioned in #112

Here is the codesandbox, if you are interested: https://codesandbox.io/s/vexflow-vextab-and-vexchords-with-react-ih6oq?file=/src/App.js

0xfe commented 3 years ago

LGTM, thanks for the nudge.

stereokai commented 2 years ago

@0xfe hey can we please publish this fix to npm? It's holding back many users... Thanks a lot! https://github.com/0xfe/vextab/issues/106 https://github.com/0xfe/vextab/issues/134 https://stackoverflow.com/questions/69341430/how-to-use-vextab-in-meteor-with-svelte