search

0xfe / vextab

A VexTab Parser for VexFlow
Other
588 stars 115 forks source link

Fix notation-vs-tab bar misalignment #122

Closed jzohrab closed 3 years ago

jzohrab commented 3 years ago

Hi @0xfe / Mohit,

This PR fixes a bar misalignment mentioned in https://github.com/0xfe/vextab/issues/99, and PR https://github.com/0xfe/vextab/pull/120. Prior to this PR, this works (bars aligned)

tabstave notation=true key=E time=12/8
notes :w 7/4 | 6/5

But this breaks (bars misaligned)

tabstave notation=true key=E time=12/8
notes :w 7/4 | 6/5 |

In this branch I added some very simple tests verifying the fix: code is rendered and the SVG is compared, eg:

image

Note that I pulled the single-line code fix from issue #99 -- I couldn't quite see why this fixed the issue, but it did! The existing tests pass.

jzohrab commented 3 years ago

Thanks @0xfe ! This will close out #99 . Cheers, jz