0xfe / vextab

A VexTab Parser for VexFlow
Other
588 stars 115 forks source link

Modernizing #159

Closed K20shores closed 1 month ago

K20shores commented 7 months ago

This PR is an attempt to modernize vextab

When I have this completed, #106 will no longer be an issue.

I've resolved many issues, but I'm not completely done and have a few left. First off, all tests pass but the tests don't appear to catch every edge case.

I'm making this draft PR because I seem to have one last issue and I don't understand what is happening well enough to debug it. I know that it seems to be the multiStringTab test, but am unclear on what causes the rendering issue

Screenshot 2024-01-25 at 10 23 57 PM

It appears that some SVG element is created incorrectly and I don't quite understand how to debug this. To view this yourself

npm i
npm run test

and then check devtools

Other issues that I have not addressed but need to:

I would appreciate any help in figuring out what is rendering incorrectly and why

K20shores commented 7 months ago

For more context, here's the published current version of vextab for the bass and 8-string:

Screenshot 2024-01-25 at 11 19 30 PM

and here is what my version is producing

Screenshot 2024-01-25 at 11 20 05 PM Screenshot 2024-01-25 at 11 20 21 PM