search

0xjessel / calchat

CalChat is a web app that hosts chatrooms for every class and building on campus with the goal of connecting the cal campus community. By logging in with Facebook, students can talk to fellow students in the same building or class, make friends, find study partners, and stay in the loop.
calchat.net
3 stars 0 forks source link

insert '@' and [space] when completing an @mention #158

Closed ricefield closed 12 years ago

ricefield commented 12 years ago

so currently when you do an @mention from the typeahead, it just inserts a persons name and also places the cursor at the end of the name, with no space.

a better behavior would probably be to insert: @First L(space) so the user can keep typing his/her chat fluidly. ive caught myself typing an @reply really fast and then having to backspace to add a space in between the @mention and the message text

pingpongboss commented 12 years ago

that was my initial behavior. then I changed it to match Facebook's. up for discussion

0xjessel commented 12 years ago

i think its fine the way it is (i'm used to how fb does it)

pingpongboss commented 12 years ago

I actually prefer with a space insert. Maybe we can try both and see which one seems more natural.

ricefield commented 12 years ago

i feel like FB's is better because they linkify and highlight the name as soon as you select it from the dropdown. we just insert normal looking text, so it feels a lot weirder.

if you try github's which is a lot similar to ours. if you do @meltedxice or @pingpongboss it will insert the name (with the @ in front, and append the space for you. feels more natural typing this way)

pingpongboss commented 12 years ago

so what do u want calchat's to be like? Keep in mind that we can't do the highlighting because it's a technical challenge that I wont be able to solve any time soon

ricefield commented 12 years ago

yeah so my point is we should just follow github's form

On Sat, Apr 14, 2012 at 6:43 PM, Mark Wei < reply@reply.github.com

wrote:

so what do u want calchat's to be like? Keep in mind that we can't do the highlighting because it's a technical challenge that I wont be able to solve any time soon

Reply to this email directly or view it on GitHub: https://github.com/meltedxice/calchat/issues/158#issuecomment-5136247

Jonathan

pingpongboss commented 12 years ago

oh ic yea that's simple enough.