search

0xpapercut / solana-substreams

Solana substreams monorepo.
11 stars 3 forks source link

redundant check for program id against raydium program address #5

Closed nabeel-uncx closed 2 months ago

nabeel-uncx commented 2 months ago

Hey while going thru the impl, i noticed there is a redundant check 

  if bs58::encode(context.get_account_from_index(instruction.program_id_index as usize)).into_string() != RAYDIUM_LIQUIDITY_POOL {

its done in parse_transaction when you iterate over each instruction as well as inside parse instruction over the passed instruction which at a glance seems redundant, or am i missing out on something ?

0xpapercut commented 2 months ago

if someone use this function in another substream, i tend to err on the side of warning bad usage.