search

0xpr03 / VocableTrainer-Android

Vocabulary Trainer for Android - not lang specific
Apache License 2.0
29 stars 10 forks source link

Black theme #73

Open yephny opened 2 years ago

yephny commented 2 years ago

Looking at the past issues, it seems like it was a trouble to implement a dark theme. Still, though, there are visual flavors to most apps and each has their own preference. Some prefer a light theme, some a dark theme like the one the app currently has, and I prefer black theme on all my apps. Apps like VocableTrainer unfortunately causes an inconsistency as they don't have a black theme option.

0xpr03 commented 2 years ago

There is a dark theme, if you switch to dark theme in your android settings.

yephny commented 2 years ago

There is but I'm talking about amoled black.

0xpr03 commented 2 years ago

That sounds like an entirely different thing. I seem to have an amoled display, but I'm not sure what you mean with a theme for that.

yephny commented 2 years ago

That's just an arbitrary name. A black or pitch/amoled/true black theme has #000000 as its background and uses #000000 whenever there is a dark shade.

Examples include

newp

in comparison to OctoDroid's dark theme octod

0xpr03 commented 2 years ago

Ok, if you want you can make a PR for theming or maybe change the current black theme. It's currently not very high on the list of todos.