search

0xrawsec / golang-evtx

GNU General Public License v3.0
158 stars 27 forks source link

*evtx.File.Events() method seems to be broken #23

Closed steve-offutt closed 4 years ago

steve-offutt commented 4 years ago

I wanted to test the parser without the concurrency. To my surprise the Events() method does not return any events. I suspect this is related to the issue in the comments of FastEvents() method: 

                // We have to create a copy here because otherwise cpc.EventsChan() fails
                // I guess that because EventsChan takes a pointer to an object and that
                // and thus the chan is taken on the pointer and since the object pointed
                // changes -> kaboom

While it's not a major issue, it would still be nice to have the non-concurrent version of the parser available.

qjerome commented 4 years ago

Hey @steve-offutt ,

Sorry for the delay, finally found the time to work on this.

The issue is now fixed.

Thanks for using the library and reporting issues.

Cheers