search

0xricksanchez / like-dbg

Fully dockerized Linux kernel debugging environment
MIT License
737 stars 58 forks source link

fix: rename hadolint input variable #128

Closed jbergstroem closed 1 year ago

jbergstroem commented 1 year ago

error-level -> error_level

This doesn't address the warning that hadolint outputs since the action is set to not error on warnings. Let me know if you want me to address that too!

jbergstroem commented 1 year ago

Come to think of it, you can probably do .dockerfile* instead of listing them manually.

0xricksanchez commented 1 year ago

Feel free for to add this to the PR. I’ll review it asap

jbergstroem commented 1 year ago

you could optionally also tell github to only run it if dockerfiles change

0xricksanchez commented 1 year ago

you could optionally also tell github to only run it if dockerfiles change

That’s something I wanted to do for all the checks for quite a bit. It probably should be done in a separate PR. Feel free to do so tho :)!

jbergstroem commented 1 year ago

@0xricksanchez: i believe i've accomplished whats needed in this PR then! I spent some time looking at the community using the action I maintain and wanted to help out / improve usage.

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.92% // Head: 89.92% // No change to project coverage :thumbsup:

Coverage data is based on head (6174077) compared to base (1da4fd8). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ======================================= Coverage 89.92% 89.92% ======================================= Files 18 18 Lines 1945 1945 ======================================= Hits 1749 1749 Misses 196 196 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=434b). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=434b)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.