0xsequence / erc-1155

Ethereum Semi Fungible Standard (ERC-1155)
https://sequence.build
Other
321 stars 118 forks source link

N3 - EIP712_DOMAIN_HASH can be calculated at runtime #33

Closed PhABC closed 4 years ago

PhABC commented 4 years ago

image

By @agusx1211

Agusx1211 commented 4 years ago

https://github.com/arcadeum/multi-token-standard/commit/5a4ef26a0be28705086d7eda1fbb3a30cc9ecfec fixes it, but the variable EIP712_DOMAIN_HASH is left unused, maybe it can be removed?

PhABC commented 4 years ago

Good catch