search

0xsequence / erc-1155

Ethereum Semi Fungible Standard (ERC-1155)
https://sequence.build
Other
320 stars 119 forks source link

The Metadata URI extension is missing its signature #53

Closed christopheradams closed 3 years ago

christopheradams commented 4 years ago

According to EIP 1155 Metadata Extensions, the supportsInterface function MUST return true for an interfaceID of 0x0e89341c when the ERC1155Metadata_URI extension is included.

However, the ERC1155MetadataMock.sol contract does not include any constants or support for this interface.

To conform to the spec, users would have to override supportsInterface and return the correct constants.

PhABC commented 4 years ago

Hey @christopheradams! We just added the uri() function signature as part of the supportsInterface. Required a few changes, but you can find it here ; https://github.com/arcadeum/multi-token-standard/blob/2191d80496c7ec795c7e6bb789fd570c52789183/contracts/tokens/ERC1155/ERC1155Metadata.sol#L63