0xsequence / erc-1155

Ethereum Semi Fungible Standard (ERC-1155)
https://sequence.build
Other
320 stars 119 forks source link

don't play well with openzepplin #68

Open cedricwalter opened 3 years ago

cedricwalter commented 3 years ago

Thanks for this great library! but updating openzeppelin-solidity to latest 4.0.0 and I can not compile my project

running but outdated combination taken from https://github.com/ProjectOpenSea/opensea-erc1155

    "multi-token-standard": "github:ProjectOpenSea/multi-token-standard",
    "openzeppelin-solidity": "^2.1.3",

How to reproduce, upgrading 3rd parties

openzeppelin-solidity 4.0.0    // use pragma solidity ^0.8.0;
@0xsequence/erc-1155 3.0.4    // use use pragma solidity ^0.7.4;

Tried both

    solc: {
      version: "^0.8.0",
    },

,ParserError: Source file requires different compiler version (current compiler is 0.8.3+commit.8d00100c.Emscripten.clang) - note that nightly builds are considered to be strictly less than
the released version
 --> @0xsequence/erc-1155/contracts/tokens/ERC1155/ERC1155MintBurn.sol:2:1:
  |
2 | pragma solidity 0.7.4;

or

    solc: {
      version: "^0.7.4",
    },

,ParserError: Source file requires different compiler version (current compiler is 0.8.3+commit.8d00100c.Emscripten.clang) - note that nightly builds are considered to be strictly less than
the released version
 --> @0xsequence/erc-1155/contracts/tokens/ERC1155/ERC1155MintBurn.sol:2:1:
  |
2 | pragma solidity 0.7.4;

what do you recommend? rollbacking openzeppelin-solidity to a previous version? hoping that I find one which stilluse Solc 0.7 branch?

pkieltyka commented 3 years ago

@cedricwalter thanks for the report -- I've noticed you closed this ticket -- did you find a solution? any updates on your experience?

thanks

cedricwalter commented 3 years ago

Yes and no, I switched to a pure Open Zeppelin ERC1155 implementation. I closed this report since it is not really an error, mixing 2 library (yours and open zeppelin), and adding truffle is something you may not want to urgently fix.

pkieltyka commented 3 years ago

Cool thanks. I'll reopen for us to look into some time in the future

aalmada commented 2 years ago

I actually prefer this implementation but want to use some other contracts from Open Zeppelin. I run into this same issue. Are you planning to upgrade to 0.8.*?

pkieltyka commented 2 years ago

@aalmada yes we will – it will be an easy upgrade too.

curious which parts you prefer in this implementation?