search

0xsuk / agitcms

Headless CMS for developers
MIT License
88 stars 8 forks source link

xterm fit addon can't manage height #10

Closed 0xsuk closed 2 years ago

0xsuk commented 2 years ago

xterm height is colsinteger, so there's a blank space when colsinteger !== parent's height, if xterm is placed at the bottom

0xsuk commented 2 years ago

https://github.com/jsmecham/atom-terminal-tab/blob/d608f7166586a9d8bffe98007b37118e8040e27b/lib/terminal-view.js#L86

0xsuk commented 2 years ago

Use cols options of new Terminal(), not css height