search

0xtlt / shopify_api

A shopify api client for rust
MIT License
14 stars 3 forks source link

update get_end_of_support_date function & test - Shopify support cont… #12

Closed davidhollenbeckx closed 1 year ago

davidhollenbeckx commented 1 year ago

hey Thomas - thanks so much for putting this crate together! it's been a very helpful starting point as I begin rewriting some of my ts shopify integrations in Rust

I ran into a minor error when I was using this today - got a warning that I was using a deprecated API version

Warning: You are using a deprecated API version
Warning: unstable API version will be used

Shopify APIs are named for the release date - so 2023-07 will be supported until 06/30/2024. Made a quick update here to correct

-- david

0xtlt commented 1 year ago

Hi @davidhollenbeckx ,

Thank you for contributing to this project. I'm constantly improving it as I work on Shopify projects using Rust. I have some upcoming work that will allow me to add important features like Bulk Operations and Mutations in the future.

In the meantime, thanks for the report and the fix!

(The test CI is failing but on my computer, the tests pass. I'll investigate. later for that)

Best regards, Thomas