search

0xtob / nitrotracker

A Fasttracker II style tracker for the Nintendo DS
94 stars 13 forks source link

Fix compatibility with latest devkitARM/libnds #61

Open asiekierka opened 4 years ago

asiekierka commented 4 years ago

Better DSi/3DS support! Some fixes in libntxm are also required (to improve SD card performance and stability, particularly on the DSi where it will crash/load very slowly otherwise) - but as of right now, the GitHub repository is behind the Google Code archive, so I'd like to know if I should wait until you update the GitHub with the latest code (either by pulling in chee's update, or by re-importing the repository with full history preserved) to push my fixes.

FreeMem=15943680byte

Fixed microphone support requires https://github.com/0xtob/libntxm/pull/2

asiekierka commented 4 years ago

Some more fixes have been added:

Further (feature-heavier) work will probably happen on a separate branch.

asiekierka commented 4 years ago

Features and tweaks beyond these (which are mostly bugfixes/optimization/cleanup, and DSi support) are currently being added to the "new" branch.

0xtob commented 4 years ago

Thanks a ton for all these fixes! I pulled https://github.com/0xtob/libntxm/pull/2 . Does this address the required fixes for this pull request?

asiekierka commented 4 years ago

Absolutely. This PR matches the libntxm PR in this regard.

Please note that the changes here cut off at a certain point - as I haven't received a response to the PR for a while, I got somewhat carried away and started developing a fork of my own with added functionality and deeper changes on the "asiekierka:new" branch (for both NitroTracker and libntxm), complete with an unofficial release and changelog made two days ago. I wanted to keep this branch solely for non-behaviour-changing fixes.

As I have written a changelog and published a release, it should be possible to get a good idea of what the changes were and how they function in practice.

It's worth discussing where we go from here. It would be nice to see all these changes become official, of course!

EDIT: The release is here - I've also ensured that the contributors whose work I used consent to relicensing their patches to tobkit under Apache 2.0, so there's no problem here.