search

1-max-1 / WASMSerialTerminal

A tool for quick analysis of data from a serial device.
https://1-max-1.github.io/WASMSerialTerminal
8 stars 3 forks source link

Added Paired Serial Port feature #7

Closed imatrisciano closed 1 year ago

imatrisciano commented 1 year ago

Added the ability to list already paired serial ports and connect to them. Connecting to an already paired serial ports does not trigger an UI request. This allows developers to open the serial communication automatically.

I was not able to obtain the serial port name or the device human readable description. Paired devices are listed by their USB Product ID and USB Vendor ID

immagine

1-max-1 commented 1 year ago

Thanks for taking the time to open a pull request!

However, I don't really see the benefit of this feature. The new number of clicks required to connect is only reduced when you reconnect to the previous device, and it is only reduced by one. I feel like the default method of letting the browser handle the device selection is perfectly fine. Especially since the browser can usually identify the type of device rather than just displaying the USB vendor and product ID. Additionally, this PR adds quite a bit of code just for this small feature, which doesn't seem like the best trade off, when we could just let the browser handle it.

Is there some other important use-case or detail that I am missing?

1-max-1 commented 1 year ago

Stale