1-minute-to-midnight / mpv-modern-x-compact

Compact version of modern-x osc for mpv with a neat web-player type UI
90 stars 3 forks source link

Migrate from shared-script-properties to user-data #11

Closed FreeTheTech101 closed 11 months ago

FreeTheTech101 commented 11 months ago

With commit 1d00aee, MPV has started throwing a warning that shared-script-properies has been deprecated. This commit removes the three uses of this property, and swaps them with their new calls.

This commit also re-syncs the update_margins function, and adds reset_margins, since the console would jump around without it. I am sure there is more rebasing to be done, and I might try in a future commit, but no promises, as LUA is not something I am familiar with.

1-minute-to-midnight commented 11 months ago

Thanks for your work 😁. I apologize for not being able to review this sooner. Got busy with uni work 😅.