1000nettles / combat-numbers

A FoundryVTT module showcasing bouncing combat numbers on tokens, similar to old-school JRPGs.
https://foundryvtt.com/packages/combat-numbers/
MIT License
5 stars 8 forks source link

Add sound to the Effect #13

Open brunocalado opened 3 years ago

brunocalado commented 3 years ago

Hi.

Can you add a field in settings to set up a sound?

Maybe a sound for damage, and one for healing.

Thank you.

1000nettles commented 3 years ago

I think I'd maybe like to keep this module pretty tightly focused on actually displaying the numbers themselves. Potentially it may be a candidate for another module that is narrowly focused on playing sounds when HP changes, or alternatively it is possible to use the recently updated https://foundryvtt.com/packages/maestro/

Thoughts?

brunocalado commented 3 years ago

I love maestro. Very good one.

But, is it possible to another module to sync the sound with the number showing up?

The simplest solution isn't add the function playsound to the start of the animation?

I don't know.

But, make a sound of your choice play when the number pop could make this great module even cooler.

apoapostolov commented 3 years ago

@1000nettles are you sure that Maetro supports sound on taking damage or heal? I use Maestro and it doesn't have that functionality (or I haven't seen it yet).