masking setting is now persistent

1000nettles / combat-numbers

A FoundryVTT module showcasing bouncing combat numbers on tokens, similar to old-school JRPGs.

https://foundryvtt.com/packages/combat-numbers/

MIT License

5 stars 8 forks source link

masking setting is now persistent #29

Closed TPNils closed 3 years ago

TPNils commented 3 years ago

See issue #26

1000nettles commented 3 years ago

Hey there! My apologies for the delay on this, I've been working on the Hey, Wait! module over the holiday break.

The issue here is that some folks still want to be able to toggle masking on / off on the fly. Let me adjust your PR slightly to still allow for that and I'll merge it. I'm thinking the setting can be "Default masking to ON" instead.

TPNils commented 3 years ago

Hi,

That behaviour should not have changed. I basically added a setting the users can't see, that is where the state is stored. So in stead of it being stored in memory, it is now persistant but still toggled via the same way.

1000nettles commented 3 years ago

Heya, I appreciate your approach but I've decided to keep the State class clean, only to be toggled by outside control. I've used your ideas in a separate merge which is now complete and available for download / update. Thank you!