1001genomes / AraGWAS

GWAS catalogue for Arabidopsis thaliana
https://aragwas.1001genomes.org
MIT License
11 stars 5 forks source link

Check if server-side periodic tasks are correctly executed #95

Open mtog opened 7 years ago

mtog commented 7 years ago

Check all periodic tasks (temp file cleaning, default file generations)

mtog commented 7 years ago

3ca48f5221df38de5d982ff7178db65934ed25e0 contributes to this. Manual check would be ideal. We will assess that once the final version deploying preloaded JSON file from aragwas_data is up and running.

timeu commented 7 years ago

the periodic tasks do run however due to some file permission issues they currently fail. I need to fix that before.

timeu commented 7 years ago

Fixed the file permission issue and will check tomorrow if they successfully ran

timeu commented 7 years ago

@mtog : https://github.com/1001genomes/AraGWAS/blob/3ca48f5221df38de5d982ff7178db65934ed25e0/aragwas_server/gwasdb/es2csv.py#L190

This will append to the existing file. This might not be the best option. We should probably use the w+ option which will truncate the file.

mtog commented 7 years ago

Sorry I confused this function with the above use of temp_file for dumping the data. Changed it.

timeu commented 7 years ago

yeah I changed the tmp folder location because the problem is that the tmp is different for the worker container which runs all the tasks and the backend server. The only thing that is shared it the HDF5_FILE_FOLDER. Actually a more reliable way of doing is to generate the file in a tmp folder (that might be local to the container) and then copy it to the HDF5_FILE_FOLDER. this way we can also make sure that the csv works before overwriting the old file. But for now this solution is fine

mtog commented 7 years ago

Perfect, thank you. I fixed a small typo in the csv file name that prevented download. We can keep this issue open to change to the more reliable way later on.

mtog commented 7 years ago

It seems that this is working, can we close this @timeu ?