100mslive / 100ms-web

A conferencing and streaming UI built with 100ms SDK.
https://examples-videoconferencing.app.100ms.live/preview/tmz-qdi-cyp
MIT License
197 stars 164 forks source link

make leave easier to click than end room #445

Closed triptu closed 3 years ago

triptu commented 3 years ago

if you have the permission to end room, this is how the UI currently looks when clicked on leave room

Screenshot 2021-10-11 at 6 45 52 PM

It's much easier to click on end room by mistake. Two things are required -

triptu commented 3 years ago

@LuizHAP can you pick this one?

Bipul-Harsh commented 3 years ago

if you have the permission to end room, this is how the UI currently looks when clicked on leave room Screenshot 2021-10-11 at 6 45 52 PM

It's much easier to click on end room by mistake. Two things are required -

  • Switch the order of end room and leave room, so leave is down and end is up.
  • Highlight the leave button with red color instead of the endroom

here you mean end room is down and leave room is up right?

Bipul-Harsh commented 3 years ago

image Can you tell me which one is the correct output you mean

Bipul-Harsh commented 3 years ago

BTW I am ready to work on it so you can assign it to me

manavdesai27 commented 3 years ago

@triptu I have previously worked on such issues. Can I work on this one?

manavdesai27 commented 3 years ago

@triptu 100ms developer dashboard is down right now?

manavdesai27 commented 3 years ago

I have made the changes but the token might have expired.

manavdesai27 commented 3 years ago

@triptu please review this PR

triptu commented 3 years ago

closed in https://github.com/100mslive/100ms-web/pull/447