100mslive / 100ms-web

A conferencing and streaming UI built with 100ms SDK.
https://examples-videoconferencing.app.100ms.live/preview/tmz-qdi-cyp
MIT License
197 stars 164 forks source link

Mac touchpad swipe gesture handling disconnects users with slow connections #629

Closed Braveado closed 1 year ago

Braveado commented 2 years ago

https://github.com/100mslive/100ms-web/blob/a86135a91dae40e7bdef7177e232cd9d68630878/src/components/conference.jsx#L54-L61

When joining a room, the referenced effect hook can disconnect users with a slow connection before they finish the room enter process. This leaves the users with the FullPageProgress component inside the conference view infinitely showing its loader due to the following lines: https://github.com/100mslive/100ms-web/blob/a86135a91dae40e7bdef7177e232cd9d68630878/src/components/conference.jsx#L63-L65

To reproduce:

  1. Set a low connection speed on the browser dev tools network tab.
  2. Refresh the page
  3. Click join as soon as possible image
raviteja83 commented 1 year ago

@Braveado possible to check this again?

raviteja83 commented 1 year ago

closing now as the relevant code mentioned above is removed.