100mslive / server-sdks

100ms server-side SDK for Node.js
5 stars 3 forks source link

Bug: Wrong TS Types for response from sdk.getRoomService().createRoom(args) #5

Open tylerzey opened 1 year ago

tylerzey commented 1 year ago

I'm receiving the following back from 100ms after calling create room:

{
  id: 'xxx',
  name: 'yyy',
  enabled: true,
  description: 'yyy',
  customer_id: 'xxx',
  recording_source_template: true,
  enabled_source_template: true,
  recording_info: null,
  template_id: '',
  template: '',
  region: 'us',
  created_at: '2022-10-31T15:22:41.01Z',
  updated_at: '2022-10-31T15:22:40.55Z',
  customer: 'xxx'
}

The typescript response interface is

export interface HMSRoom {
    id: string;
    name: string;
    description: string;
    active: boolean;
    recording_info: {
        enabled: boolean;
    };
    user_id: string;
    customer_id: string;
    created_at: string;
    updated_at: string;
}

There are quite a few difference between these two objects.