search

1010todd / Galactic-War

Repository for Endless Sky plugin "Galactic War"
GNU General Public License v3.0
16 stars 6 forks source link

Some minor errors in ship and outfit datafiles #19

Closed naigmariano closed 10 months ago

naigmariano commented 10 months ago

Found some minor errors in some data files of ships and outfits that i want to report, and here's the following:

  1. "energy capacity" of smallest erader battery (H-1AE Battery Array) is set to 99000, far bigger than the largest one that has 72000 (H-A0E Battery Array), due to a possible typo in typing of actual capacity?
  2. The left and right ship thruster flares on erader narpul ships activate when the ship turns right (also pressing the turn right button,) the data files shows that the ships have all of their "steering engine" to activate on pressing the turn right button.
  3. The dels melduklar fuel tanker uses a sprite called "ship/mgf melduklar" and "thumbnail/mgf melduklar thumb" for the ship sprite and thumbnail respectively; those files doesn't exist, as "mgf" is a prefix for Mega Freight, a different plugin not related to Galactic War. the intended files ("ship/dels melduklar" and "thumbnail/dels melduklar thumb") actually exists on the plugin's assets intended for use on said ship.

That may not be all of the bugs i found in the plugin since the last modification by the developer, but i hope the fixes will improve the quality of the plugin, even to perfection.

I could also fix said errors by forking the plugin, putting in the new fixed code, and putting up a new pull request, although i don't know if i have permission to put up a pull request?

1010todd commented 10 months ago

Thanks for the report. I'll push a fix soon. Also you can make PR to the repo and I can review it in the future.

naigmariano commented 10 months ago

Thank you so much for fixing the bug and information on PR for this repo. keep up the good work! i am now closing this issue as a new commit fixed the aformentioned bugs.