10110111 / CalcMySky

Simulator of light scattering by planetary atmospheres
GNU General Public License v3.0
29 stars 7 forks source link

/usr/bin/calcmysky lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK #19

Closed carlosal1015 closed 6 months ago

carlosal1015 commented 6 months ago

Hi, I am not sure if some action is required, otherwise is safe to ignore.

$ namcap calcmysky-0.3.2-1-x86_64.pkg.tar.zst 
calcmysky W: ELF file ('usr/bin/calcmysky') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
calcmysky W: ELF file ('usr/bin/showmysky') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
calcmysky W: ELF file ('usr/lib/libShowMySky-Qt6.so.15.0.0') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
calcmysky W: Dependency glibc detected and implicitly satisfied (libraries ['usr/lib/libc.so.6', 'usr/lib/libm.so.6'] needed in files ['usr/lib/libShowMySky-Qt6.so.15.0.0', 'usr/bin/showmysky', 'usr/bin/calcmysky'])
calcmysky W: Dependency gcc-libs detected and implicitly satisfied (libraries ['usr/lib/libstdc++.so.6', 'usr/lib/libgcc_s.so.1'] needed in files ['usr/lib/libShowMySky-Qt6.so.15.0.0', 'usr/bin/showmysky', 'usr/bin/calcmysky'])
calcmysky W: Dependency included, but may not be needed ('eigen')
calcmysky W: Dependency included, but may not be needed ('glm')
10110111 commented 6 months ago

lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK

Shadow stack is a security feature that's not critical to the function. If your distribution requires it to be enabled, it's the packager's responsibility to enable this via CMAKE_CXX_FLAGS and CMAKE_{EXE,SHARED}_LINKER_FLAGS.

detected and implicitly satisfied

Sounds OK.

Dependency included, but may not be needed

Both Eigen and GLM are header-only libraries. If a binary package includes them, then it's a mistake of packaging. Do they get installed on make install? They shouldn't.