Closed mcraiha closed 2 years ago
You probably don't want to use the actual TypeScript source (it's written in loose mode TS, which is nice for DX but doesn't have the same requirements as strict TS, which Deno uses). Instead you should use the JavaScript with the TypeScript typings file.
// Don't use the ?dts Skypack flag; it isn't necessary for Deno support
// The @deno-types comment adds TypeScript typings
// @deno-types="https://cdn.skypack.dev/fflate/lib/index.d.ts"
import * as fflate from 'https://cdn.skypack.dev/fflate?min';
Let me know if that works.
Hi,
I can already run tests with --no-check flag. It is just that I could also easily test .ts validity with Deno. Do you want a pull request from following commit? And another one for GitHub actions to test them automatically? https://github.com/mcraiha/fzstd/commit/a6af12401e8f445fa7abc7294bad3564a4c9381b
Sorry I completely missed this, please feel free to create the PR with tests. GH actions aren't necessary if they're not set up already - I usually don't use them.
From your reply I think --no-check
is acceptable for Deno users who want to use the full TS version, so I'm closing for now. TSC does the "testing" of the validity of the types when building so I don't think that part is really necessary.
Hi, I was planning to add some deno test cases for this project, but it seems deno bundle fails with following errors