search

101companies / 101worker

4 stars 11 forks source link

Error reporting in pull101repo #212

Closed kevin-klein closed 8 years ago

kevin-klein commented 8 years ago

pull101repo actually refuses a lot of repos because they don't match some url schema which it checks. The error reporting should be way better as it just appears green in the module list. The code is located here: https://github.com/101companies/101worker/blob/development/modules/pull101repo/Repo101/Pull.pm#L100

hartenfels commented 8 years ago

Are you sure about that? Looking at the repo list, it seems more like that a bunch of URLs are broken.

There's a bunch of URLs like https://github.com/kevin-klein/kevin-klein/aced_rails/tree/master/lib/generators/aced_rails, which don't match the regex – but that's correct, it's not a valid GitHub URL and gives 404. The correct URL would be https://github.com/kevin-klein/aced_rails/tree/master/lib/generators/aced_rails (without the second kevin-klein), which again does match the regex.

It seems like all recent submissions are broken that way. So probably nothing wrong with pull101repo and fixing the links should make the issue go away.

(Error reporting could be better though, the number of failed repos could be used for the exit code for example.)

kevin-klein commented 8 years ago

I could see that they did not match the regex, i just think we should address this in some way because nobody was aware of that as far as i know.