101companies / 101worker

4 stars 11 forks source link

Fix issue with escaped backslash in executor for windows #222

Closed alexsr closed 8 years ago

alexsr commented 8 years ago

On windows, run_module did not work, if it was executed using FileFullSweepExecutor because the backslash was not escaped properly.

alexsr commented 8 years ago

This actually did not do what I thought it did. The issue still remains, that modules are not run correctly because somehow files are not found.

kevin-klein commented 8 years ago

I thought so too, for me it worked flawlessly. Get in touch with the facebook group for further advise please.

alexsr commented 8 years ago

I found a fix that actually fixes the issue for me. should I create a new pull request or simple post it here?

kevin-klein commented 8 years ago

Please open a new pull request.

2016-05-22 20:09 GMT+02:00 Alexander Scheid-Rehder <notifications@github.com

:

I found a fix that actually fixes the issue for me. should I create a new pull request or simple post it here?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/101companies/101worker/pull/222#issuecomment-220846934