1024jp / GzipSwift

Swift package that enables gzip/gunzip Data using zlib
MIT License
544 stars 134 forks source link

Swift Package manager, Linux support #9

Closed michael-yuji closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 80.58% (diff: 100%)

Merging #9 into master will increase coverage by 0.38%

@@             master         #9   diff @@
==========================================
  Files             2          2          
  Lines           202        206     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            162        166     +4   
  Misses           40         40          
  Partials          0          0          

Powered by Codecov. Last update bf52dbc...872d56f

1024jp commented 8 years ago

thanks, I'll review your pr when I have time (sorry but I'm now quite busy.

michael-yuji commented 8 years ago

No problem. I added some more fix (NSLocalizedString not available on Linux) and some instructions in the readme file as well.

zarghol commented 8 years ago

@1024jp It's been more than a month now, can you merge it now please, it could be useful for users of SPM in the server :)

1024jp commented 8 years ago

Sorry for my late. I've just merged the p-r (without test). Please tell me if it doesn't work.

zarghol commented 8 years ago

Thanks ! to use this repo in SPM, we need a release with a version to show, like 3.0.2 or 3.1 or whatever

1024jp commented 8 years ago

@zarghol I see. I'll do it just now.

1024jp commented 8 years ago

I've tagged it as 3.1.0.

zarghol commented 8 years ago

Thanks ! I can get in my project ! 👍

zarghol commented 8 years ago

well it half works, because of tests : swift-package: error: the package has an unsupported layout, unexpected source file(s) found: XXX/Packages/GzipSwift-3.1.0/Tests/GzipTests.swift fix: move the file(s) inside a module in the Package.swift of the project, you can exclude directory to not include in spm

let package = Package( name: "MyProject", dependencies: [ .Package(url: "https://github.com/vapor/vapor.git", majorVersion: 1, minor: 1), .Package(url: "https://github.com/vapor/sqlite-provider.git", majorVersion: 1, minor: 1), .Package(url: "https://github.com/1024jp/GzipSwift", versions: Version(0,0,0)..<Version(5,0,0)) ], exclude: [ "Config", "Database", "Localization", "Public", "Resources", "Tests", ])

So can you add Tests to exclude ? or do you want a PR just for this ?

1024jp commented 8 years ago

@zarghol I added a test for SPM instead of excluding it. Does it work? Please tell me if I need to tag another version.

1024jp commented 8 years ago

I forgot to mention it. I also changed package name (framework name?) from GzipSwift to Gzip.

zarghol commented 8 years ago

ok I'll test it

zarghol commented 8 years ago

well, your changes isn't part of a Release, so I can't retrieve it

1024jp commented 8 years ago

So you mean I need another tag like 3.1.1?

zarghol commented 8 years ago

yes, because your last modification isn't in the 3.1 SPM check version via git tags, so if I want a package in a version A, I need a tag A. if I specify a Version Range like Version(0,0,0)..<Version(5,0,0), SPM will check the last version in the range and if there is no version with your modification, I can't get it

1024jp commented 8 years ago

Ok, then, I've updated to 3.1.1.

zarghol commented 8 years ago

Thank you, I'll re-test soon