search

103sbavert / JADA

JADA - Just Another Dictionary App
MIT License
20 stars 0 forks source link

Br Portuguese doesn't work #3

Closed GiovanniSalmeri closed 3 years ago

GiovanniSalmeri commented 3 years ago

Installed from IzzyOnDroid, v. 4.4.0 All works flawlessly, except for Br Portuguese: when selected no definition is found (tried with several common protuguese words) and moreover the option for changing the language disappears (I was forced to reinstall). Thank you!

103sbavert commented 3 years ago

Hello, thank you for showing your interest in my app, that means a lot.

Installed from IzzyOnDroid, v. 4.4.0 All works flawlessly, except for Br Portuguese: when selected no definition is found (tried with several common protuguese words)

After doing some debugging I found out about issue: 102. Apparently, this is part of the gradual migration to the new api and support for Portuguese may be dropped from the API. I will try to bring it back but I can't make any promises.

the option for changing the language disappears (I was forced to reinstall). Thank you!

I have fixed the underlying reason but this will no longer be verifiable since I will also be removing support for the languages that don't work until I find a different api that supports more languages.

If you don't mind, I would like to know if you are a Portuguese speaker as that will help me understand if my users really use other languages.

GiovanniSalmeri commented 3 years ago

Thank you very much for taking the time for this issue. I have read https://github.com/meetDeveloper/freeDictionaryAPI/issues/102 : it would be really unfortunate if support for non-English languages were dropped from the API... I am not a Portuguese speaker (I am Italian), but quite often I read texts in other languages: your app is extremely useful for those who have a limited knowledge of a foreign language, because normally a dictionary entry explains a (unknown) word by means of more common (and known) words. Some minutes after me, also my wife (whose mother tongue is French) installed it!

103sbavert commented 3 years ago

I am planning to buy this and if I manage to afford it, I will update my app to use that api and close this issue. If you can help me with donations, feel free to reply, most of us developers are broke students in their teens (or at least so is the case for me).

GiovanniSalmeri commented 3 years ago

Will the definitions be so complete as now? Trying the box "Enter a word to test the API" at page https://developer.oxforddictionaries.com/ only the first definition presently shown in JADA appears. Anyway, I will gladly contribute if this helps you (and the app :smile:)

103sbavert commented 3 years ago

Which word did you look up? It may just be showing a truncated version since it's just to test the api. Maybe if I can make a throwaway to check if the definitions are as complete.

On Mon, Sep 13, 2021, 00:58 GiovanniSalmeri @.***> wrote:

Will the definitions be so complete as now? Trying the box "Enter a word to test the API" at page https://developer.oxforddictionaries.com/ only the first definition presently shown in JADA appears. Anyway, I will gladly contribute if this helps you (and the app 😄)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sbeve72/JADA/issues/3#issuecomment-917695846, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWJ6MCX2RIHZSSAG2YXVJ3UBT5M7ANCNFSM5D4CN5SA .

GiovanniSalmeri commented 3 years ago

I tried several words, for example "freedom": in JADA five meanings, there only the first.

103sbavert commented 3 years ago

Thanks for letting me know. I am testing this right now.

On Mon, Sep 13, 2021, 01:08 GiovanniSalmeri @.***> wrote:

I tried several words, for example "freedom": in JADA five meanings, there only the first.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sbeve72/JADA/issues/3#issuecomment-917697500, or unsubscribe https://github.com/notifications/unsubscribe-auth/APWJ6MA4CXOZQUVPGWV65JTUBT6VDANCNFSM5D4CN5SA .

103sbavert commented 3 years ago

@GiovanniSalmeri Apparently, it works fine if you have an api key. This api seems more efficient to me if I manage to buy the developer package. For now I need to build the Pojos and other stuff.

103sbavert commented 3 years ago

Mitigated with commit 2308a4c51ec533c29f73b92101b9a06c713a97ec.

JADA 5 supports different languages (Portuguese no longer on the list). Issues like word not found should no longer occur as often with JADA 5.