104corp / php-taiwan-bank

台灣的銀行代碼查詢 SDK for PHP
BSD 3-Clause "New" or "Revised" License
1 stars 2 forks source link

Add another resource #4

Closed Tai-ch0802 closed 6 years ago

Tai-ch0802 commented 6 years ago

因為原本銀行局的data裡面沒有包含 700 郵局,所以上網找了其他來源加進去

參考來源是從這份專案上找到的

codecov-io commented 6 years ago

Codecov Report

Merging #4 into master will increase coverage by 2.79%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #4      +/-   ##
===========================================
+ Coverage     89.11%   91.9%   +2.79%     
- Complexity       37      41       +4     
===========================================
  Files             8       9       +1     
  Lines           147     173      +26     
===========================================
+ Hits            131     159      +28     
+ Misses           16      14       -2
Impacted Files Coverage Δ Complexity Δ
src/Bank/Resource/CsvFile.php 0% <ø> (ø) 5 <0> (?)
src/Bank/Resource/OpenDataFromGovernmentBank.php 100% <ø> (ø) 4 <0> (?)
src/Bank/Resource/Resource.php 100% <ø> (ø) 1 <0> (?)
...source/OpenDataFromFinancialInformationService.php 100% <100%> (ø) 4 <4> (?)
src/Bank/Factory.php 100% <100%> (+6.06%) 6 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e401068...e1d0c90. Read the comment docs.

MilesChou commented 6 years ago

太強了!