107-systems / 107-Arduino-MCP2515

Arduino library for controlling the MCP2515 in order to receive/transmit CAN frames.
https://107-systems.org
MIT License
88 stars 14 forks source link

Enable CMake Support #93

Closed joerossrobotics closed 1 year ago

joerossrobotics commented 1 year ago

Enable CMake Support

Changes:

Testing:

github-actions[bot] commented 1 year ago

Memory usage change @ fc1d57d8f4653ec5de04394c784897801d96c023

Board flash % RAM for global variables %
arduino:renesas_portenta:portenta_c33 :small_red_triangle: +76 - +80 0.0 - 0.0 :small_red_triangle: +16 - +16 0.0 - 0.0
arduino:renesas_uno:minima :small_red_triangle: +80 - +80 +0.03 - +0.03 :small_red_triangle: +16 - +16 +0.05 - +0.05
arduino:samd:mkrzero :small_red_triangle: +76 - +76 +0.03 - +0.03 :small_red_triangle: +16 - +16 +0.05 - +0.05
rp2040:rp2040:rpipico :small_red_triangle: +32 - +32 0.0 - 0.0 :small_red_triangle: +16 - +16 +0.01 - +0.01
Click for full report table Board|`examples/MCP2515-CAN-Sniffer`
flash|%|`examples/MCP2515-CAN-Sniffer`
RAM for global variables|%|`examples/MCP2515-Filter`
flash|%|`examples/MCP2515-Filter`
RAM for global variables|%|`examples/MCP2515-Loopback`
flash|%|`examples/MCP2515-Loopback`
RAM for global variables|% -|-|-|-|-|-|-|-|-|-|-|-|- `arduino:renesas_portenta:portenta_c33`|80|0.0|16|0.0|80|0.0|16|0.0|76|0.0|16|0.0 `arduino:renesas_uno:minima`|80|0.03|16|0.05|80|0.03|16|0.05|80|0.03|16|0.05 `arduino:samd:mkrzero`|76|0.03|16|0.05|76|0.03|16|0.05|76|0.03|16|0.05 `rp2040:rp2040:rpipico`|32|0.0|16|0.01|32|0.0|16|0.01|32|0.0|16|0.01
Click for full report CSV ``` Board,examples/MCP2515-CAN-Sniffer
flash,%,examples/MCP2515-CAN-Sniffer
RAM for global variables,%,examples/MCP2515-Filter
flash,%,examples/MCP2515-Filter
RAM for global variables,%,examples/MCP2515-Loopback
flash,%,examples/MCP2515-Loopback
RAM for global variables,% arduino:renesas_portenta:portenta_c33,80,0.0,16,0.0,80,0.0,16,0.0,76,0.0,16,0.0 arduino:renesas_uno:minima,80,0.03,16,0.05,80,0.03,16,0.05,80,0.03,16,0.05 arduino:samd:mkrzero,76,0.03,16,0.05,76,0.03,16,0.05,76,0.03,16,0.05 rp2040:rp2040:rpipico,32,0.0,16,0.01,32,0.0,16,0.01,32,0.0,16,0.01 ```
aentinger commented 1 year ago

Can you add a CI workflow for performing a simple smoke test, I.e. build this library? For inspiration you can take a look here:

aentinger commented 1 year ago

https://github.com/107-systems/107-Arduino-Cyphal/blob/main/.github/workflows/smoke-test.yml

joerossrobotics commented 1 year ago

I've implemented the smoke test

aentinger commented 1 year ago

This fixes #92 .

aentinger commented 1 year ago

God, this was a mess.

@joerossrobotics please test.

aentinger commented 1 year ago

I've just realized these changes have zero correlation with the purpose of this open source project but just fit your very narrow scope. Furthermore you're using this for a commercial product so I am basically helping you for free ... 🤦‍♂️ . If you want custom work, you can contact me for a paid contract.