search

1080linebooks / sigil

Automatically exported from code.google.com/p/sigil
GNU General Public License v3.0
0 stars 0 forks source link

"open next/previuos HTML section" buttons (next/prev with regard to reading order) #792

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
During ePub file editing with a big quantity of sections (>100) it is very 
difficult to find the next section file in the tree view, especially after 
"chapter break", when tree view has been refreshed and focus jumps to the top 
of the tree (in my case the quantity of section is bigger than 500).

It would be very useful to add two navigation buttons/menu action items with 
two options: "open next section file"/"open prev section file".

Original issue reported on code.google.com by ibl...@gmail.com on 14 Mar 2011 at 1:45

GoogleCodeExporter commented 9 years ago

Original comment by Strahinja.Markovic@gmail.com on 14 Mar 2011 at 10:05

GoogleCodeExporter commented 9 years ago

Original comment by Strahinja.Markovic@gmail.com on 21 Jul 2011 at 9:43

GoogleCodeExporter commented 9 years ago 
Patch attached adding controls/keyboard shortcuts to open previous/next file in 
the book browser relative to the file currently in the selected tab.

Original comment by meme90...@gmail.com on 23 Dec 2011 at 10:31

Attachments:

GoogleCodeExporter commented 9 years ago 
The attached patch has a few issues.

1) I don't think the buttons at the bottom of the window are necessary.

2) Open an image file, click the next or previous file button or use the menu 
item and Sigil crashes.

3) Since we're only dealing with defined directions it would be better to use 
an enumeration where the directions are members. Look at FindText in 
FindReplace.

4) What should be the action to take when the person has an image or other type 
of file open? Should it do nothing, go to a text file, go to the next item of 
the item type?

Original comment by john@nachtimwald.com on 1 Jan 2012 at 1:31

GoogleCodeExporter commented 9 years ago 

1) Without the buttons there's no obvious sign to the user that the 
functionality exists.  OK, there are Window menu items with keyboard shortcuts, 
but they might not be easily discoverable or preferred for some users.  I think 
feedback from people who might use the feature would be helpful.

2) Sounds like a bit more testing is needed :)  Glad you caught this.

3) ok

4) This was originally about moving through the text files, but given the image 
issue in 2, and that there will be other file types, I'll need to review this.  
I'm leaning towards moving through the complete list of files/types.

Original comment by meme90...@gmail.com on 1 Jan 2012 at 4:44

GoogleCodeExporter commented 9 years ago 
New completely rewritten patch - includes 2 separate issues due to heavily 
shared code

1. Open previous/next file with buttons/shortcuts
- Adds two buttons on main window and keyboard shortcuts for previous/next file
- Opens the previous/next file in the book browser relative to the currently 
opened tab
- Only moves to previous/next in same entry type and only for Text, Style, 
Images
- Does not wrap around when it reaches the start/end of a section to avoid 
getting 'lost'
- Uses the OPFModel item lists instead of the original incorrect resource lists
- Moves bulk of work to OPFModel

2. Select/highlight newly opened/activated tabs in the book browser
- Selects/highlights entries in the book browser corresponding to newly opened 
tabs or newly activated tabs
- Handles removal of files/merge with previous
- Supports previous/next actions by tracking the current tab in the book browser
- Supports issue 1135 which opens a blank/merged entry in a new tab by 
highlighting it
- Still allows for manually selecting entries in book browser
- Automatically scrolls/expands browser as necessary

Possible issues
- If you click the current tab header the selection is not updated (suggestions 
on how to capture correct mouse click?)
- Windows Menu entry doesn't show key shortcuts like Close Tab although they do 
work and can be changed

Original comment by meme90...@gmail.com on 11 Jan 2012 at 12:23

GoogleCodeExporter commented 9 years ago 
Patch.

Original comment by meme90...@gmail.com on 11 Jan 2012 at 1:11

Attachments:

GoogleCodeExporter commented 9 years ago 
New patch changing the functionality slightly:
- move previous or next relative to the selected entry in the book browser 
instead of current tab
- moved buttons from next to zoom on main window to the bottom of the book 
browser
- changed buttons to up/down to be consistent with book browser
- moved all functionality from main window to book browser

Original comment by meme90...@gmail.com on 11 Jan 2012 at 8:13

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by meme90...@gmail.com on 24 Jan 2012 at 7:46

GoogleCodeExporter commented 9 years ago

Original comment by john@nachtimwald.com on 28 Jan 2012 at 2:08

GoogleCodeExporter commented 9 years ago

Original comment by daveheil...@gmail.com on 19 May 2012 at 3:20