10bestdesign / jqvmap

jQuery Vector Map Library
https://www.10bestdesign.com/jqvmap/
Other
1.82k stars 681 forks source link

[Fix] booleano import error #324

Open elvismdev opened 6 years ago

elvismdev commented 6 years ago

What does this PR do ?

Fixes error:

:~/WWW/jqvmap/create$ python jqvmap.py config/country-name.json
Traceback (most recent call last):
  File "jqvmap.py", line 11, in <module>
    from booleano.parser import Grammar, EvaluableParseManager, SymbolTable, Bind
ImportError: cannot import name EvaluableParseManager

How should this be tested ?

With

Run

python jqvmap.py config/country-name.json

// config/country-name.json

[
  {
    "name": "read_data",
    "file_name": "./source/gadm36_CUB_shp/gadm36_CUB_0.shp"
  },
  {
    "name": "write_data",
    "format": "jqvmap",
    "file_name": "./output/jquery.vmap.country-name.js",
    "params": {
      "code_field": "ISO",
      "name_field": "NAME_ENGLI",
      "name": "country-name"
    }
  }
]

What are the relevant issues ?

https://github.com/bjornd/jvectormap/issues/352#issuecomment-315216980

This Pull Request includes:

What gif best describes how you feel about this work ?

cool

iqnaul commented 6 years ago

Hi, I'm still experiencing error message: ImportError: cannot import name 'EvaluableParseManager'

I have booleano correctly installed, do you have any suggestion?

elvismdev commented 6 years ago

@iqnaul This PR fixes that, but it has still to be merged to master. In the meantime you could manually apply this change on your end https://github.com/10bestdesign/jqvmap/pull/324/commits/75487ab6554aea8a49458456ba74e09b150418da

iqnaul commented 6 years ago

okay thank you @elvismdev I applied this and try it but still experience about utf-8 encoding

elvismdev commented 6 years ago

@iqnaul utf-8 encoding looks like a separate issue from what this PR fixes.