Feature/selected border color - Githubissues

10bestdesign / jqvmap

jQuery Vector Map Library

https://www.10bestdesign.com/jqvmap/

Other

1.82k stars 681 forks source link

Feature/selected border color #344

Open xoxefdp opened 5 years ago

xoxefdp commented 5 years ago

What does this PR do ?

adds a parameter that enables region border to change when onRegionSelect or onRegionDeselect occurs if parameter not null

How should this be tested ?

adding selectedBorderColor: #color / rgba( color, opacity ) to jqvmap selector object, check border color changes when region selects and deselects

What are the relevant issues ?

None, it is a feature

This Pull Request includes:

[ ] Bug Fix with passing npm test
[x] New Feature with passing npm test
[x] Code Improvement with passing npm test
[x] Updated Documentation
[ ] New Map File & Example HTML

FYI tests didn't pass even in original master branch

What gif best describes how you feel about this work ?

not_bad_meme