search

10quality / wpmvc-commands

Ayuco commands for Wordpress MVC,
MIT License
2 stars 4 forks source link

Deprecate SetNameCommand in favour of SetCommand #59

Closed garretthyder closed 4 years ago

garretthyder commented 4 years ago

Updates #28 to deprecate the SetName command in favour of the Set command.

@amostajo would love your review/feedback as this is a larger PR.

I'm not sure if we should expand on the basic SetNamespaceTest.php I created to cover the Model/Controller updates?

I did leave SetNameCommand.php but updated so it uses the SetCommand, I wasn't sure if we wanted to fully remove the command?

I also left SetNameCommand defined in the use statement of the tests > environment > ayuco file, figured you'd replace that with another ayuco.

Also I wasn't sure the appropriate approach to updating the ayuco executable for this type of change as SetName is baked in here - https://github.com/10quality/ayuco

amostajo commented 4 years ago

@garretthyder fantastic job. If you wish to add more tests, you are welcome!

I will be adding changes and unit testing because something broke when updating the namespace on composer.json. Not related to your pull request.

Also will add --no-plugins on autodump.