search

10se1ucgo / DisableWinTracking

Uses some known methods that attempt to minimize tracking in Windows 10
GNU Lesser General Public License v3.0
4.98k stars 368 forks source link

Silent mode does not perform all available options #419

Closed ghost closed 3 years ago

ghost commented 5 years ago

INFORMATION:

Cross-referencing the settings for silent vs window mode, the following are missing in silent mode.

Also dwt_util.defender is present but commented.

It seems like it's impossible for dwt_util.app_manager to ever be called, otherwise that would be missing as well.

ghost commented 5 years ago

Note this is not necessarily an issue, however misleading since the following is stated in the readme.

This will perform all available options of the version you're using.

DeeJayhX commented 5 years ago

It likely doesn't include the Xbox DVR option that was recently added, an oversight by the person who added it and an oversight by myself in review, I'll look into the others.

ghost commented 5 years ago

Got it. Primarily I'm noticing that the host file isn't getting updated when run in silent mode, also from the code it looks like the IP blocking is also not happening, but I haven't verified in any runs.

DeeJayhX commented 5 years ago

I believe there was an original reason why those were left out of the silent run, but I can't remember specifically why. The silent parameter was added so long ago...

ghost commented 5 years ago

I ran a quick search for all issues with "silent" and it seems none of them discuss the host file.

I think whether or not it's added is not as big of an issue as correctly indicating in the readme what is done and what isn't.

Or even better, allow passing parameters for what the user wants to run. But not necessary. I think most people who go to the extent to run something like this will likely be checking all the boxes anyways.