search

10secondsofcode / coding-ai

CodingAI is an open source application and it helps to find a mentor related your technologies stack.
https://mentors.10secondsofcode.com
MIT License
81 stars 103 forks source link

app restructure suggestion #59

Closed Sreilys closed 4 years ago

Sreilys commented 5 years ago

Worked on this Issue: https://github.com/10secondsofcode/coding-ai/issues/17

I had some suggestion in mind:

elangosundar commented 5 years ago

Worked on this Issue: #17

I had some suggestion in mind:

  • file names
  • improve use of router and switch plus typos
  • added some comments here and there to explain what I was thinking when I changed the code :)
  • I left the search functionality not complete on purpose so that someone else could take it ad a task
  • would be nice to provide id field for the data, so that we could create the MentorProfile component

@Sreilys thanks for your valuable feedback for apps suggestions. I will go through and will update the feedback. I will pull your modified changes in local and will merge. Thanks a lot your help.