Feature/updated linting - Githubissues

10up / 10up-experience

The 10up Experience plugin configures WordPress to better protect and inform clients, aligned to 10up’s best practices.

GNU General Public License v2.0

129 stars 27 forks source link

Feature/updated linting #144

Closed darylldoyle closed 1 year ago

darylldoyle commented 1 year ago

Description of the Change

This PR updates the linting within the repo to lint CSS/JS and PHP using the 10up standards.

It adds in ESlint and StyleLint from the 10up toolkit.
It adds lint-staged and husky to ensure that future PRs align with the code styles.
It updates the linting Github Action to use the new configs
It fixes a bunch of PHPCS errors that were being flagged.

How to test the Change

Smoketest the plugin.
Run linters
- npm run lint-js
- npm run lint-style
- composer run lint

Changelog Entry

Added - Additional linting.
Changed - The linting standards to align with the 10up standards.
Fixed - PHPCS errors/warnings.

Credits

Props @darylldoyle

Checklist:

[x] I agree to follow this project's Code of Conduct.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my change.
[x] All new and existing tests pass.