10up / 10up-experience

The 10up Experience plugin configures WordPress to better protect and inform clients, aligned to 10up’s best practices.
GNU General Public License v2.0
129 stars 27 forks source link

When deployed on WordPress VIP, duplicate plugin update messages are visible in the network admin #160

Open chriseagle opened 4 months ago

chriseagle commented 4 months ago

Describe the bug

On the network plugin screen, 2 update messages appear for plugins which have an update available.

From VIP Support

We have potentially identified the source of the duplication. We do not rely on core's notice since users cannot update plugins from the plugin dashboard but we add the notification manually here:

https://github.com/Automattic/vip-go-mu-plugins/blob/develop/codebase-manager/plugins/plugins-manager.php#L17

And at the same time it seems like 10up is doing the same here: https://github.com/wpcomvip/gus-wp/blob/trunk-built/plugins/10up-experience/includes/classes/Plugins/Plugins.php#L181

Steps to Reproduce

n/a

Screenshots, screen recording, code snippet

Screenshot 2024-04-18 at 09 01 21

Environment information

No response

WordPress information

No response

Code of Conduct