Adjust markup for radio and checkbox fields to match WordPress Core - Githubissues

10up / 10up-experience

The 10up Experience plugin configures WordPress to better protect and inform clients, aligned to 10up’s best practices.

GNU General Public License v2.0

129 stars 27 forks source link

Adjust markup for radio and checkbox fields to match WordPress Core #92

Closed claytoncollie closed 1 year ago

claytoncollie commented 3 years ago

Description of the Change

Addresses #41 to fix the alignment of checkbox and radio fields in the wp-admin. Radios and checkboxes now follow the same markup as WordPress Core.

Benefits

Accessibility and keyboard usability of the admin pages should be a little cleaner with these changes.

Possible Drawbacks

Breaking the settings fields.

Verification Process

How did you verify that all new functionality works as expected?

Installed the plugin on a local instance, made my changes and saved each settings field multiple times:

Disable Gutenberg - https://tenup.test/wp-admin/options-writing.php

Enable Password Protection - https://tenup.test/wp-admin/options-writing.php

Enable Support Monitor - https://tenup.test/wp-admin/options-general.php

Production Environment - https://tenup.test/wp-admin/options-general.php

And also for multisite - https://tenup.test/wp-admin/network/settings.php

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.

Changelog Entry

Changed admin markup for Disable Gutenberg, Enable Password Protection, Enable Support Monitor, and Production Environment