Feature/coding style updates 2019 09

10up / Engineering-Best-Practices

10up Engineering Best Practices

https://10up.github.io/Engineering-Best-Practices/

MIT License

760 stars 205 forks source link

Feature/coding style updates 2019 09 #311

Closed mmcachran closed 2 years ago

mmcachran commented 5 years ago

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my change.
[x] All new and existing tests passed.

Applicable Issues

None

Changelog Entry

Added coding style documentation for easier debugging and code cleanup.

jeffpaul commented 5 years ago

@aaemnnosttv any updated review feedback based on @mmcachran latest changes here?

jeffpaul commented 5 years ago

@mmcachran back to you on this one

mmcachran commented 5 years ago

Thanks, @aaemnnosttv! Back to you for review 🙂

bengreeley commented 4 years ago

@aaemnnosttv @mmcachran I'm good with this addition to the best practices to avoid nested logic/if statements.

@tlovett1 thoughts?

tlovett1 commented 4 years ago

Hey @mmcachran thanks for putting this together. The first part about nested logic definitely makes sense to me. The second part about checking array keys feels a bit subjective. Can you split that off into a separate PR?

jeffpaul commented 4 years ago

@tlovett1 this looks like it may be good to merge, yeah?

jeffpaul commented 4 years ago

@tlovett1 any concerns with us merging this in?