10up / Engineering-Best-Practices

10up Engineering Best Practices
https://10up.github.io/Engineering-Best-Practices/
MIT License
760 stars 205 forks source link

Rename master/slave in Systems.md #340

Closed darylldoyle closed 4 years ago

darylldoyle commented 4 years ago

Renamed master/slave terminology to primary/replica.

Description of the Change

This PR changes the master/slave terminology to use primary/replica when talking about databases within System.md. This PR will close https://github.com/10up/Engineering-Best-Practices/issues/339.

Benefits

Brings the best practice document inline with 10up's policy on naming conventions.

Possible Drawbacks

None that I can see.

Checklist:

Applicable Issues

Changelog Entry

## Changed
- Database relationship naming from `master` to `primary` and from `slave` to `replica`
jeffpaul commented 4 years ago

Confirmed with @TheLastCicada that this is good to merge, will click the Big Green Button™️ momentarily.

jeffpaul commented 4 years ago

Nice catch and thanks for the PR @darylldoyle!