10up / Engineering-Best-Practices

10up Engineering Best Practices
https://10up.github.io/Engineering-Best-Practices/
MIT License
760 stars 205 forks source link

GitHub Security tab overtaken by our security.md file #347

Closed jeffpaul closed 4 years ago

jeffpaul commented 4 years ago

Describe the bug When you navigate to the GitHub Security tab in this repo, you get served content from https://github.com/10up/Engineering-Best-Practices/blob/gh-pages/security.md since GitHub expects a SECURITY.md file for this page.

Potential resolution Change the name of https://github.com/10up/Engineering-Best-Practices/blob/gh-pages/security.md to site-security.md and update references throughout the code?

ciprianimike commented 4 years ago

@jeffpaul I was going to work on this task but the bug is unconfirmed, even though the file for the site's security page is still called security.md.

Recorderd screen: security-tab

jeffpaul commented 4 years ago

@ciprianimike what do you see if you click on the Security Policy section of the Security tab? Link should be: https://github.com/10up/Engineering-Best-Practices/security/policy

ciprianimike commented 4 years ago

@jeffpaul Issue replicated, please assign this to me, I'll fix it