Updated render blocking statement to be more generic - Githubissues

10up / Engineering-Best-Practices

10up Engineering Best Practices

https://10up.github.io/Engineering-Best-Practices/

MIT License

760 stars 205 forks source link

Updated render blocking statement to be more generic #375

Closed dainemawer closed 3 years ago

dainemawer commented 3 years ago

Description of the Change

Updated some language that could lead engineers to believe that ensuring that there is no render-blocking behaviour on sites is a must to solve.

Benefits

Ensure that the "render-blocking" statement is more generic, its not an absolute to achieve it on projects if its not viable from a time, cost, and practicality perspective.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my change.
[x] All new and existing tests passed.

Changelog Entry

Updated render-blocking scripts statement in Performance.md

tlovett1 commented 3 years ago

Thanks Daine!