search

10up / MU-Migration

This WP-CLI plugin makes the process of moving sites from single WordPress sites to a Multisite instance (or vice-versa) much easier. It exports everything into a zip package which can be used to automatically import it within the desired Multisite installation.
MIT License
329 stars 47 forks source link

Housekeeping #20

Closed noplanman closed 6 years ago

noplanman commented 7 years ago

I really like this plugin/package and am super grateful for your work on it! Has been so incredibly helpful to me.

Would you be open for a general housekeeping of the code? I love nice-looking code and would love to contribute more.

The functionality would obviously stay the same, this is mainly for the visual poetry part of the code 😇 (with some extras of slight optimisations)

I set the points up as checkboxes, as I'd be making a PR for each one, to keep it manageable and easy for you to check the changes.

What do you say?

nicholasio commented 7 years ago

I'd love to see some improvements here. My only concern is with possibly introducing regression with "Slight code optimisations/modifications". Perhaps we should tackle #5 first. I have been avoiding making huge changes to the code until adding unit tests to the plugin. But I don't see huge risks with the first three items.

noplanman commented 7 years ago

My only concern is with possibly introducing regression

Yes, I totally understand that and agree with you. Having unit tests will be great! (We'll continue that discussion on #5)

I'll start with the first 3 point of this issue to also become more familiar with the code 👍

noplanman commented 7 years ago

@nicholasio Have updated the top comment and added the first 3 PRs for you to check out.

corradomatt commented 7 years ago

Would you be open to a PR with updated documentation in the README.md and/or in the CLI output? Some things aren't complete / 100% clear.

nicholasio commented 7 years ago

@corradomatt sure. Feel free to submit a PR.