search

10up / action-wordpress-plugin-deploy

Deploy your plugin to the WordPress.org repository using GitHub Actions
MIT License
530 stars 92 forks source link

Github workflow/action based files in SVN #84

Open ndeet opened 2 years ago

ndeet commented 2 years ago

Describe the bug The Github workflow run produces three new files that end up in the SVN. Not sure if they are new or have been there for some time and this is known but I get these unrelated files in the SVN:

Not sure if it matters but I use a composer based deployment step that runs composer install that could cause this?

Steps to Reproduce

  1. Create a tag so the deployment workflow
  2. Check the deployed files on WordPress SVN repo

Expected behavior Not sure but those files seems to contain debugging information not relevant to the published plugin.

Is it save to add those three files to .distignore?

jeffpaul commented 2 years ago

@ndeet can you please link to your repo / latest action run to better triage?

ndeet commented 2 years ago

Hi @jeffpaul thanks for the quick reply.

The GH action run: https://github.com/btcpayserver/woocommerce-greenfield-plugin/runs/5274673242?check_suite_focus=true

The SVN Repo: https://plugins.trac.wordpress.org/browser/btcpay-greenfield-for-woocommerce/trunk

Thank you.

jeffpaul commented 2 years ago

@ndeet I'm not seeing an immediate cause here, but adding those files to your .distignore should remove them from SVN and stop from having them sent in the future. I'll keep this open in case others can jump in and help triage why those files are introduced and if there's a way to protect for that within the action itself.

richard-muvirimi commented 2 years ago

These files are created by the docker image used for composer setup, you can refer to the issue that explains the use of a docker image Automatically created docker packages after using this action

github-actions[bot] commented 2 years ago

This issue has been automatically closed because there has been no response to our request for more information. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. See this blog post on bug reports and the importance of repro steps for more information about the kind of information that may be helpful.