search

10up / ads-txt

Ads.txt Manager for WordPress: Manage your ads.txt and app-ads.txt files in the WordPress dashboard
https://wordpress.org/plugins/ads-txt/
GNU General Public License v2.0
57 stars 25 forks source link

Minimum WP and PHP version bumped to 5.7 and 7.4 #103

Closed jayedul closed 2 years ago

jayedul commented 2 years ago

Description of the Change

Minimum WP and PHP version requirement bumped to 5.7 and 7.4 respectively.

Closes #102

How to test the Change

There's really nothing to test as only the minimum required version bumped. No functional change was necessary for it.

Changelog Entry

Minimum WP and PHP version requirement bumped to 5.7 and 7.4 respectively.

dkotter commented 2 years ago

@jayedul Thanks for this! The code changes here look good but there are a few other things we'll want to change as well, in regards to our testing.

Currently we run PHP scanning against PHP 5.6+ (see https://github.com/10up/ads-txt/blob/develop/.github/workflows/php8-compatibility.yml#L23). We should change that to only be 7.4+ now.

In addition, our e2e tests run against a minimum environment of WP 4.9 (see https://github.com/10up/ads-txt/blob/develop/.github/workflows/test-e2e.yml#L15). That should be bumped to 5.7 now.

jayedul commented 2 years ago

Thank you @dkotter There's a new push on it.