10up / ads-txt

Ads.txt Manager for WordPress: Manage your ads.txt and app-ads.txt files in the WordPress dashboard
https://wordpress.org/plugins/ads-txt/
GNU General Public License v2.0
57 stars 23 forks source link

PHP Compatibility Workflow doesn't require a matrix #106

Closed peterwilsoncc closed 1 year ago

peterwilsoncc commented 1 year ago

Describe the bug

As the PHP Compatibility checker uses a tokenizer to evaluate compatibility (as opposed to code execution), it can be run on a single version of PHP rather than as part of a matrix.

The test version can be listed as 7.4- to test for compatibility with all supported versions of PHP.

This will require a change to the protected branch config to remove the redundant runs as required checks.

Steps to Reproduce

N/A

Screenshots, screen recording, code snippet

Docs: https://github.com/PHPCompatibility/PHPCompatibility#testversion-in-the-ruleset-versus-command-line

Environment information

No response

WordPress information

No response

Code of Conduct

Sidsector9 commented 1 year ago

Related discussion on Slack - https://10up.slack.com/archives/C84M9AA06/p1648460113851159