search

10up / block-components

A collection of components built to be used in the block editor
https://www.npmjs.com/package/@10up/block-components
269 stars 41 forks source link

Image component uploading state #273

Open johnwatkins0 opened 1 year ago

johnwatkins0 commented 1 year ago

Is your enhancement related to a problem? Please describe.

Currently, the Image component does not change state when an image is uploading. So if you upload a large image, there may be several seconds where nothing is happening. As a user this can be confusing. I suggest adding callback props to the component, one that runs when an upload starts and another that runs when an upload finishes. This way our components that use the Image component can provide an upload state. Alternatively, the Image component could handle that state itself.

https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/media-placeholder/README.md#onfilespreupload onFilesPreUpload is probably useful.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

IayushCoderJOD commented 8 months ago

@johnwatkins0 @fabiankaegy Can you assign me this issue?

Sidsector9 commented 2 months ago

@IayushCoderJOD the issue has been assigned to you.